-
-
Notifications
You must be signed in to change notification settings - Fork 346
test(e2e): Add auto init from JS tests for Android #4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
krystofwoldrich
wants to merge
39
commits into
capture-app-start-errors
from
kw-add-android-auto-init-tests
Closed
test(e2e): Add auto init from JS tests for Android #4602
krystofwoldrich
wants to merge
39
commits into
capture-app-start-errors
from
kw-add-android-auto-init-tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issing is also valid
…w-add-auto-init-tests-ios
…w-add-app-start-crash-ios
…w-add-android-auto-init-tests
I'm currently investigating why Android tests with auto init are not returning app start. I'm getting an error message that the app was in the background on start.
|
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
18a5066+dirty | 1244.20 ms | 1251.54 ms | 7.34 ms |
b6d933c+dirty | 1228.02 ms | 1235.32 ms | 7.30 ms |
1a89392+dirty | 1229.00 ms | 1234.78 ms | 5.78 ms |
c8578fb+dirty | 1225.49 ms | 1224.29 ms | -1.20 ms |
208f4af+dirty | 1213.08 ms | 1223.82 ms | 10.73 ms |
454f971+dirty | 1233.51 ms | 1239.18 ms | 5.67 ms |
8d0daf6+dirty | 1227.80 ms | 1236.83 ms | 9.03 ms |
b75148e+dirty | 1202.72 ms | 1212.04 ms | 9.32 ms |
5625ce7+dirty | 1219.73 ms | 1223.80 ms | 4.07 ms |
555070f+dirty | 1223.61 ms | 1227.57 ms | 3.96 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
18a5066+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
b6d933c+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
1a89392+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
c8578fb+dirty | 3.19 MiB | 4.30 MiB | 1.12 MiB |
208f4af+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
454f971+dirty | 3.19 MiB | 4.31 MiB | 1.12 MiB |
8d0daf6+dirty | 3.19 MiB | 4.30 MiB | 1.12 MiB |
b75148e+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
5625ce7+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
555070f+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8d0daf6+dirty | 393.58 ms | 394.84 ms | 1.26 ms |
454f971+dirty | 439.04 ms | 423.88 ms | -15.16 ms |
1a89392+dirty | 425.56 ms | 530.65 ms | 105.09 ms |
b75148e+dirty | 428.91 ms | 461.26 ms | 32.35 ms |
18a5066+dirty | 370.06 ms | 414.10 ms | 44.04 ms |
b6d933c+dirty | 398.43 ms | 456.62 ms | 58.19 ms |
5625ce7+dirty | 358.15 ms | 416.65 ms | 58.50 ms |
555070f+dirty | 388.25 ms | 424.44 ms | 36.19 ms |
c8578fb+dirty | 374.17 ms | 362.06 ms | -12.11 ms |
208f4af+dirty | 346.93 ms | 402.77 ms | 55.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8d0daf6+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
454f971+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
1a89392+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
b75148e+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
18a5066+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
b6d933c+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
5625ce7+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
555070f+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
c8578fb+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
208f4af+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
18a5066+dirty | 1218.00 ms | 1212.27 ms | -5.73 ms |
b6d933c+dirty | 1217.71 ms | 1220.58 ms | 2.87 ms |
1a89392+dirty | 1220.12 ms | 1216.69 ms | -3.43 ms |
c8578fb+dirty | 1218.55 ms | 1217.23 ms | -1.32 ms |
208f4af+dirty | 1209.44 ms | 1217.13 ms | 7.70 ms |
454f971+dirty | 1220.55 ms | 1225.82 ms | 5.27 ms |
8d0daf6+dirty | 1230.90 ms | 1233.16 ms | 2.27 ms |
b75148e+dirty | 1221.53 ms | 1220.85 ms | -0.68 ms |
5625ce7+dirty | 1226.98 ms | 1217.77 ms | -9.21 ms |
555070f+dirty | 1213.59 ms | 1217.79 ms | 4.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
18a5066+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
b6d933c+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
1a89392+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
c8578fb+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
208f4af+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
454f971+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
8d0daf6+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
b75148e+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
5625ce7+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
555070f+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b6d933c | 442.52 ms | 461.82 ms | 19.30 ms |
8d0daf6 | 422.36 ms | 449.40 ms | 27.04 ms |
454f971 | 436.27 ms | 478.76 ms | 42.48 ms |
b75148e | 440.04 ms | 421.36 ms | -18.68 ms |
18a5066 | 427.89 ms | 436.47 ms | 8.57 ms |
555070f | 438.67 ms | 428.30 ms | -10.37 ms |
1a89392 | 412.59 ms | 424.69 ms | 12.10 ms |
5625ce7 | 476.74 ms | 488.24 ms | 11.50 ms |
c8578fb | 397.17 ms | 415.72 ms | 18.55 ms |
208f4af | 439.23 ms | 427.31 ms | -11.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b6d933c | 17.75 MiB | 20.11 MiB | 2.37 MiB |
8d0daf6 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
454f971 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
b75148e | 17.75 MiB | 20.11 MiB | 2.37 MiB |
18a5066 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
555070f | 17.75 MiB | 20.11 MiB | 2.37 MiB |
1a89392 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
5625ce7 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
c8578fb | 17.75 MiB | 20.11 MiB | 2.36 MiB |
208f4af | 17.75 MiB | 20.11 MiB | 2.37 MiB |
d05e789
to
2363742
Compare
Closing this because the branch is outdated. And the sample app is using different test suit. Maestro instead of Detox. (See #4619 for context) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Runs the sample e2e test suit with the new manual init and the original auto init from JS.